Skip to content

repl: migrate errors to internal/errors #17716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kysnm wants to merge 7 commits into from
Closed

repl: migrate errors to internal/errors #17716

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f237327
repl: migrate errors to internal/errors
kysnm Dec 17, 2017
4f918bb
Check the err.code instead of the err.message
kysnm Dec 18, 2017
65fc1e8
Remove useless test
kysnm Dec 18, 2017
fed6d47
Change the contents of the error message in detail
kysnm Dec 18, 2017
3dcabb7
Check the actual error message instead of the generate it
kysnm Dec 18, 2017
480358b
Describe more details at the docs.
kysnm Dec 19, 2017
f142f84
Remove useless parenthses.
kysnm Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove useless test
  • Loading branch information
@kysnm
kysnm committed Dec 18, 2017
commit 65fc1e872a31363e24a3c46acd5bf0d465cb7578
7 changes: 0 additions & 7 deletions test/parallel/test-internal-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,13 +341,6 @@ assert.strictEqual(
);
}

// Test ERR_SCRIPT_EXECUTION_INTERRUPTED
assert.strictEqual(
errors.message('ERR_SCRIPT_EXECUTION_INTERRUPTED'),
'Script execution interrupted.'
);


// Test that `code` property is mutable and that changing it does not change the
// name.
{
Expand Down