-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
console: make console more standard compliant #17708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add standard console tests
This imports a standard test from w3c/web-platform-tests (console-is-a-namespace).
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| 'use strict'; | ||
|
|
||
| // Should be above require, because code in require read console | ||
| // what we are trying to avoid | ||
| // set should be earlier than get | ||
|
|
||
| global.console = undefined; | ||
|
|
||
| // Initially, the `console` variable is `undefined`, since console will be | ||
| // lazily loaded in the getter. | ||
|
|
||
| require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| // global.console's getter is called | ||
| // Since the `console` cache variable is `undefined` and therefore false-y, | ||
| // the getter still calls NativeModule.require() and returns the object | ||
| // obtained from it, instead of returning `undefined` as expected. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incomprehensible comment... I'd remove it.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After reading it... I totally agree. I have no idea what it stands for. |
||
|
|
||
| assert.strictEqual(global.console, undefined, 'first read'); | ||
| assert.strictEqual(global.console, undefined, 'second read'); | ||
|
|
||
| global.console = 1; | ||
| assert.strictEqual(global.console, 1, 'set true-like primitive'); | ||
|
|
||
| global.console = 0; | ||
| assert.strictEqual(global.console, 0, 'set false-like primitive, again'); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| 'use strict'; | ||
|
|
||
| require('../common'); | ||
|
|
||
| const assert = require('assert'); | ||
| const { test, assert_equals, assert_true, assert_false } = | ||
| require('../common/wpt'); | ||
|
|
||
| assert.doesNotThrow(() => { | ||
| global.console = global.console; | ||
| }); | ||
|
|
||
| const self = global; | ||
|
|
||
| /* eslint-disable */ | ||
| /* The following tests are copied from */ | ||
| /* WPT Refs: | ||
| https://github.com/w3c/web-platform-tests/blob/40e451c/console/console-is-a-namespace.any.js | ||
| License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html | ||
| */ | ||
|
|
||
| // https://heycam.github.io/webidl/#es-namespaces | ||
| // https://console.spec.whatwg.org/#console-namespace | ||
|
|
||
| test(() => { | ||
| assert_true(self.hasOwnProperty("console")); | ||
| }, "console exists on the global object"); | ||
|
|
||
| test(() => { | ||
| const propDesc = Object.getOwnPropertyDescriptor(self, "console"); | ||
| assert_equals(propDesc.writable, true, "must be writable"); | ||
| assert_equals(propDesc.enumerable, false, "must not be enumerable"); | ||
| assert_equals(propDesc.configurable, true, "must be configurable"); | ||
| assert_equals(propDesc.value, console, "must have the right value"); | ||
| }, "console has the right property descriptors"); | ||
|
|
||
| test(() => { | ||
| assert_false("Console" in self); | ||
| }, "Console (uppercase, as if it were an interface) must not exist"); | ||
|
|
||
|
|
||
| // test(() => { | ||
| // const prototype1 = Object.getPrototypeOf(console); | ||
| // const prototype2 = Object.getPrototypeOf(prototype1); | ||
|
|
||
| // assert_equals(Object.getOwnPropertyNames(prototype1).length, 0, "The [[Prototype]] must have no properties"); | ||
| // assert_equals(prototype2, Object.prototype, "The [[Prototype]]'s [[Prototype]] must be %ObjectPrototype%"); | ||
| // }, "The prototype chain must be correct"); | ||
| /* eslint-enable */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cryptic comment. Maybe this?