Skip to content

http: add rawPacket in err of clientError event #17672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 6 commits into from
Closed

http: add rawPacket in err of clientError event #17672

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9eb792
http: add rawPacket in err of `clientError` event
XadillaX Dec 14, 2017
5e1369f
update after addaleax' review
XadillaX Dec 15, 2017
0e73e2c
update after addaleax' review
XadillaX Dec 15, 2017
9758fb1
update after bnoordhuis' review
XadillaX Dec 18, 2017
008e5a8
update
XadillaX Dec 18, 2017
7fb6c62
long line
XadillaX Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update after addaleax' review
  • Loading branch information
@XadillaX
XadillaX committed Dec 15, 2017
commit 0e73e2c9fd62f0c2ed19b753e997f6fac3ff59b1
5 changes: 5 additions & 0 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,11 @@ changes:
description: The default action of calling `.destroy()` on the `socket`
will no longer take place if there are listeners attached
for `clientError`.
- version: VERSION
Copy link
Copy Markdown
Member

@addaleax addaleax Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REPLACEME is a string that will get picked up by release tooling ):

pr-url: https://github.com/nodejs/node/pull/17672
description: The rawPacket is the current buffer that just parsed. Adding
this buffer to the error object of clientError event is to make
it possible that developers can log the broken packet.
-->

* `exception` {Error}
Expand Down