Skip to content

src,stream: use SetAccessorProperty instead of SetAccessor #17665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jure wants to merge 16 commits into from
Closed

src,stream: use SetAccessorProperty instead of SetAccessor #17665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
329e162
Change to using SetAccessorProperty instead of SetAccessor in StreamBase
jure Dec 13, 2017
dcca3a5
Remove extra parentheses
jure Dec 13, 2017
ebbe147
Fix indentation
jure Dec 14, 2017
a03028f
Check for TypeError instead of matching error msg
jure Dec 14, 2017
06d8157
Change PrototypeTemplate SetAccessor to SetAccessorProperty
jure Dec 14, 2017
0b96b12
Changing SetAccessor to SetAccessorProperty in udp_wrap
jure Dec 14, 2017
26ffff1
Change InstanceTemplate SetAccessor to SetAccessorProperty
jure Dec 14, 2017
9292fa0
Change InstanceTemplate SetAccessor to SetAccessorProperty
jure Dec 14, 2017
354008a
Fix indentation and linting errors in node_crypto
jure Dec 14, 2017
a199e07
Fixes for indentation
jure Dec 14, 2017
5eb6507
Add more tests for UDP and crypto
jure Dec 14, 2017
232d2be
Fixes for indentation
jure Dec 14, 2017
d89578a
Use env->as_external to get access to Environment in callback
jure Dec 14, 2017
5a60daa
More env->as_external to get access to Environment in callback
jure Dec 14, 2017
84905d6
Use env->as_external in node_perf too
jure Dec 14, 2017
73aaf0e
Update comments
jure Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes for indentation
  • Loading branch information
@jure
jure committed Dec 14, 2017
commit a199e07e68620a17100f23434da3bf96ca2cde6c
32 changes: 16 additions & 16 deletions src/node_perf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,28 +337,28 @@ void Init(Local<Object> target,
Local<Signature> signature = Signature::New(env->isolate(), pe);

Local<FunctionTemplate> get_performance_entry_name_templ =
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryName,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryName,
Local<Value>(),
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Dec 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know they didn't use to get env->as_external(), so this should be fine. But for sake of consistency I'd rather still have env->as_external() here.

Copy link
Copy Markdown
Contributor Author

@jure jure Dec 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that makes sense. Done 👍

signature);

Local<FunctionTemplate> get_performance_entry_type_templ =
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryType,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryType,
Local<Value>(),
signature);

Local<FunctionTemplate> get_performance_entry_start_time_templ =
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryStartTime,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryStartTime,
Local<Value>(),
signature);

Local<FunctionTemplate> get_performance_entry_duration_templ =
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryDuration,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetPerformanceEntryDuration,
Local<Value>(),
signature);

Local<ObjectTemplate> ot = pe->InstanceTemplate();
ot->SetAccessorProperty(env->name_string(),
Expand Down
24 changes: 12 additions & 12 deletions src/stream_base-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,22 @@ void StreamBase::AddMethods(Environment* env,
Local<Signature> signature = Signature::New(env->isolate(), t);

Local<FunctionTemplate> get_fd_templ =
FunctionTemplate::New(env->isolate(),
GetFD<Base>,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetFD<Base>,
Local<Value>(),
signature);

Local<FunctionTemplate> get_external_templ =
FunctionTemplate::New(env->isolate(),
GetExternal<Base>,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetExternal<Base>,
Local<Value>(),
signature);

Local<FunctionTemplate> get_bytes_read_templ =
FunctionTemplate::New(env->isolate(),
GetBytesRead<Base>,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
GetBytesRead<Base>,
Local<Value>(),
signature);

t->PrototypeTemplate()->SetAccessorProperty(env->fd_string(),
get_fd_templ,
Expand Down
8 changes: 4 additions & 4 deletions src/udp_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ void UDPWrap::Initialize(Local<Object> target,
Local<Signature> signature = Signature::New(env->isolate(), t);

Local<FunctionTemplate> get_fd_templ =
FunctionTemplate::New(env->isolate(),
UDPWrap::GetFD,
Local<Value>(),
signature);
FunctionTemplate::New(env->isolate(),
UDPWrap::GetFD,
Local<Value>(),
signature);

t->PrototypeTemplate()->SetAccessorProperty(env->fd_string(),
get_fd_templ,
Expand Down