Skip to content

stream,net: slightly more consistent typechecking #17644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

stream,net: slightly more consistent typechecking #17644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abd7658
stream: remove `undefined` check
addaleax Dec 13, 2017
1a7918c
net: remove Socket.prototype.write
addaleax Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: remove Socket.prototype.write 
This is superfluous now that typechecking in `net` and
`stream` are aligned.
  • Loading branch information
@addaleax
addaleax committed Dec 13, 2017
commit 1a7918ca9ec42fd0be63f05b1ffe446a8a7794c7
11 changes: 0 additions & 11 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,17 +701,6 @@ protoGetter('localPort', function localPort() {
});


Socket.prototype.write = function(chunk, encoding, cb) {
if (typeof chunk !== 'string' && !(chunk instanceof Buffer)) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE',
'chunk',
['string', 'Buffer'],
chunk);
}
return stream.Duplex.prototype.write.apply(this, arguments);
};


Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
// If we are still connecting, then buffer this for later.
// The Writable logic will buffer up any more writes while
Expand Down