Skip to content

Module search security 8830 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iankronquist wants to merge 2 commits into from
Closed

Module search security 8830 #176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
350d6e8
Add test for issue #8830
iankronquist Dec 16, 2014
095e605
Fix node_modules directory search security risk
iankronquist Dec 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for issue #8830 
nodejs/node-v0.x-archive#8830
https://groups.google.com/forum/#!searchin/nodejs/node_modules$20security/nodejs/5BGr5dliUIk/abJEH3sPymcJ
  • Loading branch information
@iankronquist
iankronquist committed Dec 16, 2014
commit 350d6e8e209c20b068810ef8f41f169bb8cc3c5b
27 changes: 25 additions & 2 deletions test/simple/test-module-nodemodulepaths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,40 @@ var module = require('module');

var isWindows = process.platform === 'win32';

var file, delimiter, paths;
var file, delimiter, paths, expected_paths, old_home;

if (isWindows) {
file = 'C:\\Users\\Rocko Artischocko\\node_stuff\\foo';
delimiter = '\\'
expected_paths = [
'C:\\Users\\Rocko Artischocko\\node_stuff\\foo\\node_modules',
'C:\\Users\\Rocko Artischocko\\node_stuff\\node_modules',
'C:\\Users\\Rocko Artischocko\\node_modules'
];
old_home = process.env.USERPROFILE;
process.env.USERPROFILE = 'C:\\Users\\Rocko Artischocko';
} else {
file = '/usr/test/lib/node_modules/npm/foo';
delimiter = '/'
expected_paths = [
'/usr/test/lib/node_modules/npm/foo/node_modules',
'/usr/test/lib/node_modules/npm/node_modules',
'/usr/test/lib/node_modules',
'/usr/test/node_modules'
];
old_home = process.env.HOME;
process.env.HOME = '/usr/test';
}

paths = module._nodeModulePaths(file);

assert.ok(paths.indexOf(file + delimiter + 'node_modules') !== -1);
assert.ok(Array.isArray(paths));
assert.deepEqual(expected_paths, paths);
assert.ok(Array.isArray(paths));

// Restore mocked home directory environment variables for other tests
if (isWindows) {
Copy link
Copy Markdown
Contributor

@isaacs isaacs Dec 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part necessary? Each test is run in a separate process, so the env gets reset.

Copy link
Copy Markdown
Contributor Author

@iankronquist iankronquist Dec 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be. That would simplify the test.

process.env.USERPROFILE = old_home;
} else {
process.env.HOME = old_home;
}