Skip to content

assert: improve simple assert #17581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 5 commits into from
Closed

assert: improve simple assert #17581

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb42659
assert: improve simple assert
BridgeAR Dec 9, 2017
07fdaf3
assert: throw without args in ok
BridgeAR Jan 15, 2018
10b24cc
doc: remove double line break
BridgeAR Jan 15, 2018
963f443
fixup simple assert
BridgeAR Jan 16, 2018
83907e4
fixup
BridgeAR Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup simple assert
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 16, 2018
commit 963f44330019b36544518272a5fafc91aafd225a
8 changes: 5 additions & 3 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ const codeCache = new Map();
// Escape control characters but not \n and \t to keep the line breaks and
// indentation intact.
// eslint-disable-next-line no-control-regex
const escapeSequencesRegExp = /[\x00-\x08\x0b-\x1f]/g;
const escapeSequencesRegExp = /[\x00-\x07\x0b-\x1f]/g;
const meta = [
'\\u0000', '\\u0001', '\\u0002', '\\u0003', '\\u0004',
'\\u0005', '\\u0006', '\\u0007', '\\b', '',
'', '\\u000b', '\\f', '\\r', '\\u000e',
'', '\\u000b', '\\f', '\\u000e',
'\\u000f', '\\u0010', '\\u0011', '\\u0012', '\\u0013',
'\\u0014', '\\u0015', '\\u0016', '\\u0017', '\\u0018',
'\\u0019', '\\u001a', '\\u001b', '\\u001c', '\\u001d',
Expand Down Expand Up @@ -188,8 +188,10 @@ function innerOk(args, fn) {
.replace(escapeSequencesRegExp, escapeFn);
message = 'The expression evaluated to a falsy value:' +
`${EOL}${EOL} assert${ok}(${message})${EOL}`;
codeCache.set(identifier, message);
}
// Make sure to always set the cache! No matter if the message is
// undefined or not
codeCache.set(identifier, message);
} catch (e) {
// Invalidate cache to prevent trying to read this part again.
codeCache.set(identifier, undefined);
Expand Down