Skip to content

util: add util.inspect compact option #17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 7 commits into from
Closed

util: add util.inspect compact option #17576

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d76d28d
util: add util.inspect structured option
BridgeAR Dec 9, 2017
ecf019e
util: rename util.inspect argument
BridgeAR Dec 9, 2017
843a5d5
util: fix custom inspect description
BridgeAR Dec 9, 2017
cd5be74
util: switch inspect "base" order
BridgeAR Dec 9, 2017
e2792d5
squash - change to "compact", add more tests, fix \n issue
BridgeAR Dec 17, 2017
e31fd8a
squash - add another test
BridgeAR Dec 17, 2017
684b992
squash - address comment
BridgeAR Dec 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
util: rename util.inspect argument 
util.inspect can actually receive any property and the description
was wrong so far. This fixes it by renaming the argument to
value and also updating the description.
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 10, 2017
commit ecf019e8e7bca7495cf6b262b81989d8cf5d7780
10 changes: 5 additions & 5 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,14 @@ function debuglog(set) {
}

/**
* Echos the value of a value. Tries to print the value out
* Echos the value of any input. Tries to print the value out
* in the best way possible given the different types.
*
* @param {Object} obj The object to print out.
* @param {any} value The value to print out.
* @param {Object} opts Optional options object that alters the output.
*/
/* Legacy: obj, showHidden, depth, colors*/
function inspect(obj, opts) {
/* Legacy: value, showHidden, depth, colors*/
function inspect(value, opts) {
// Default options
const ctx = {
seen: [],
Expand Down Expand Up @@ -301,7 +301,7 @@ function inspect(obj, opts) {
}
if (ctx.colors) ctx.stylize = stylizeWithColor;
if (ctx.maxArrayLength === null) ctx.maxArrayLength = Infinity;
return formatValue(ctx, obj, ctx.depth);
return formatValue(ctx, value, ctx.depth);
}
inspect.custom = customInspectSymbol;

Expand Down