Skip to content

tls: use correct class name in deprecation message #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

tls: use correct class name in deprecation message #17561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tls: use correct class name in deprecation message 
`tls.Socket` does not exist, and the deprecation message
should refer to `tls.TLSSocket` (like the documentation
for the deprecation message already does).
  • Loading branch information
@addaleax
addaleax committed Dec 9, 2017
commit 3b4fc6d9fca159fc959f80d60b4d33bc18ef6d6a
2 changes: 1 addition & 1 deletion lib/_tls_legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,6 @@ module.exports = {
createSecurePair:
internalUtil.deprecate(createSecurePair,
'tls.createSecurePair() is deprecated. Please use ' +
'tls.Socket instead.', 'DEP0064'),
'tls.TLSSocket instead.', 'DEP0064'),
pipe
};
2 changes: 1 addition & 1 deletion test/parallel/test-tls-legacy-deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const tls = require('tls');

common.expectWarning(
'DeprecationWarning',
'tls.createSecurePair() is deprecated. Please use tls.Socket instead.'
'tls.createSecurePair() is deprecated. Please use tls.TLSSocket instead.'
);

assert.doesNotThrow(() => tls.createSecurePair());