Skip to content

Update test-http-response-status-message to use Countdown #17552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 1 commit into from
Closed

Update test-http-response-status-message to use Countdown #17552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: use Countdown instead of testsComplete
  • Loading branch information
@Leko
Leko committed Dec 8, 2017
commit 4d13b8b0e06f64f3f99227f81d91ca8dc65bf87f
12 changes: 4 additions & 8 deletions test/parallel/test-http-response-status-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,12 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
const Countdown = require('../common/countdown');
const assert = require('assert');
const http = require('http');
const net = require('net');

let testsComplete = 0;

const testCases = [
{ path: '/200', statusMessage: 'OK',
response: 'HTTP/1.1 200 OK\r\n\r\n' },
Expand All @@ -49,6 +48,7 @@ testCases.findByPath = function(path) {
return matching[0];
};

const countdown = new Countdown(testCases.length, common.mustCall(() => {}));
const server = net.createServer(function(connection) {
connection.on('data', function(data) {
const path = data.toString().match(/GET (.*) HTTP\/1\.1/)[1];
Expand All @@ -71,7 +71,7 @@ function runTest(testCaseIndex) {
assert.strictEqual(testCase.statusMessage, response.statusMessage);

response.on('end', function() {
testsComplete++;
countdown.dec();

if (testCaseIndex + 1 < testCases.length) {
runTest(testCaseIndex + 1);
Expand All @@ -85,7 +85,3 @@ function runTest(testCaseIndex) {
}

server.listen(0, function() { runTest(0); });

process.on('exit', function() {
assert.strictEqual(testCases.length, testsComplete);
});