Skip to content

tools,doc: lint for additional strings in docs #17492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

tools,doc: lint for additional strings in docs #17492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab3535d
doc: use correct and consistent typography for products
Trott Dec 6, 2017
68da4b0
tools: lint for additional strings in docs
Trott Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: use correct and consistent typography for products 
Use `GitHub` rather than `Github` and `Node.js` rather than `Node.JS`.
  • Loading branch information
@Trott
Trott committed Dec 6, 2017
commit ab3535d6aaff310c107834574812a41406c2d674
6 changes: 3 additions & 3 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ change. In the case of pull requests proposed by an existing
Collaborator, an additional Collaborator is required for sign-off.

In some cases, it may be necessary to summon a qualified Collaborator
or a Github team to a pull request for review by @-mention.
or a GitHub team to a pull request for review by @-mention.
[See "Who to CC in issues"](./doc/onboarding-extras.md#who-to-cc-in-issues)

If you are unsure about the modification and are not prepared to take
Expand Down Expand Up @@ -156,7 +156,7 @@ or documentation.
* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run `npm install && npm test`
on a large selection of common modules. This is useful to check whether a
change will cause breakage in the ecosystem. To test Node.JS ABI changes
change will cause breakage in the ecosystem. To test Node.js ABI changes
you can run [`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/).

* [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/)
Expand Down Expand Up @@ -403,7 +403,7 @@ Changes" section of the release notes.

Collaborators may opt to elevate pull requests or issues to the [TSC][] for
discussion by assigning the `tsc-review` label or @-mentioning the
`@nodejs/tsc` Github team. This should be done where a pull request:
`@nodejs/tsc` GitHub team. This should be done where a pull request:

- is labeled `semver-major`, or
- has a significant impact on the codebase, or
Expand Down