Skip to content

tls: unconsume stream on destroy #17478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

tls: unconsume stream on destroy #17478

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e95cc8a
tls: unconsume stream on destroy
addaleax Dec 6, 2017
b7949b0
[squash] bridgear comment
addaleax Dec 12, 2017
a951088
[squash] reference test
addaleax Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] bridgear comment
  • Loading branch information
@addaleax
addaleax committed Dec 12, 2017
commit b7949b03ae068638de8b5925f9ce4827ef009d0b
4 changes: 1 addition & 3 deletions test/parallel/test-tls-transport-destroy-after-own-gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,17 @@
// Unfortunately, this tests only "works" reliably when checked with valgrind or
Copy link
Copy Markdown
Contributor

@hybrist hybrist Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity: I assume "works" in this context means "doesn't raise memory leak errors"..? And properly running the test is just using the --valgrind option?

Copy link
Copy Markdown
Member Author

@addaleax addaleax Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkrems Yeah – it complains about accessing released memory when run with valgrind. “Unfortunately”, most of the time that doesn’t lead to crashes…

Running the test file with --valgrind should make that reflected in the exit code, yes :)

// a similar tool.

/* eslint-disable no-unused-vars */

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const { TLSSocket } = require('tls');
const makeDuplexPair = require('../common/duplexpair');

let { clientSide } = makeDuplexPair();

let clientTLS = new TLSSocket(clientSide, { isServer: false });
// eslint-disable-next-line no-unused-vars
let clientTLSHandle = clientTLS._handle;

setImmediate(() => {
Expand Down