Skip to content

src: some refactoring of node_url.cc #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

src: some refactoring of node_url.cc #17470

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e86f577
src: minor cleanups to node_url.cc
addaleax Dec 5, 2017
c28a3a4
src: move url internals into anonymous namespace
addaleax Dec 5, 2017
363ad6a
src: make url host a proper C++ class
addaleax Dec 5, 2017
c8bef2d
src: use correct OOB check for IPv6 parsing
addaleax Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: make url host a proper C++ class 
- Gives `URLHost` a proper destructor that clears memory
  depending on the type of the host (This fixes a memory leak)
- Hide the host type enums and class layout as implementation details
- Make the `Parse` methods members of `URLHost`
- Turn `WriteHost` into a `ToString()` method on the `URLHost` class
- Verify that at the beginning of a parse attempt, the type is set
  to “failed”
- Remove a lot of `goto`s from the source code 🐢🚀

Fixes: #17448
  • Loading branch information
@addaleax
addaleax committed Dec 5, 2017
commit 363ad6aeb319fbb23137f143fdb9483c74ab0ab0
Loading