Skip to content

Enhance Cipheriv, Decipheriv coverage #17458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 3 commits into from
Closed

Enhance Cipheriv, Decipheriv coverage #17458

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
378abff
test: add missing test about crypto.Cipheriv()
Leko Dec 4, 2017
b7dee5e
test: add missing test about crypto.Decipheriv()
Leko Dec 4, 2017
e0e2275
test: use factory method instead of constructor
Leko Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add missing test about crypto.Decipheriv() 
- Call constructor without new keyword
- Call constructor with cipher is not string
- Call constructor with cipher is string and key is not string
- Call constructor with cipher is strong, key is string and iv is not string
  • Loading branch information
@Leko
Leko committed Dec 4, 2017
commit b7dee5e3b40ddf06e73dc02011dae99af552c434
36 changes: 36 additions & 0 deletions test/parallel/test-crypto-cipheriv-decipheriv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,42 @@ function testCipher3(key, iv) {
});
}

{
const Decipheriv = crypto.Decipheriv;
const key = '123456789012345678901234';
const iv = '12345678';

const instance = Decipheriv('des-ede3-cbc', key, iv);
assert(instance instanceof Decipheriv, 'Decipheriv expected to return a new' +
' instance when called without `new`');

common.expectsError(
() => new Decipheriv(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "cipher" argument must be of type string'
});

common.expectsError(
() => new Decipheriv('des-ede3-cbc', null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "key" argument must be one of type string, Buffer, ' +
'TypedArray, or DataView'
});

common.expectsError(
() => new Decipheriv('des-ede3-cbc', key, null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "iv" argument must be one of type string, Buffer, ' +
'TypedArray, or DataView'
});
}

testCipher1('0123456789abcd0123456789', '12345678');
testCipher1('0123456789abcd0123456789', Buffer.from('12345678'));
testCipher1(Buffer.from('0123456789abcd0123456789'), '12345678');
Expand Down