Skip to content

Enhance Cipher, Decipher coverage #17449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 11 commits into from
Closed

Enhance Cipher, Decipher coverage #17449

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3495998
test: Add test call Cipher without new keyword
Leko Dec 4, 2017
24553fa
test: add test call Decipher withour new keyword
Leko Dec 4, 2017
569099c
test: add test call Cipher with cipher is not string
Leko Dec 4, 2017
bb5c70d
test: add test call Cipher with cipher is string and password is not …
Leko Dec 4, 2017
ab7a803
test: add test call Cipher#update with data is not string
Leko Dec 4, 2017
8c60d1d
test: add test call Cipher#setAuthTag with tagbuf is not string
Leko Dec 4, 2017
435bd16
test: add test call Cipher#setAAD with aadbuf is not string
Leko Dec 4, 2017
4ebbe67
test: add test call Decipher with cipher is not string
Leko Dec 4, 2017
f15c054
test: add test call Decipher with cipher is string and password is no…
Leko Dec 4, 2017
b503bd5
test: adjust indent
Leko Dec 4, 2017
9a809ff
test: use factory method instead of constructor
Leko Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions test/parallel/test-crypto-cipher-decipher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,81 @@ testCipher1(Buffer.from('MySecretKey123'));
testCipher2('0123456789abcdef');
testCipher2(Buffer.from('0123456789abcdef'));

{
const Cipher = crypto.Cipher;
const instance = crypto.Cipher('aes-256-cbc', 'secret');
Copy link
Copy Markdown
Contributor

@maclover7 maclover7 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createCipher

Copy link
Copy Markdown
Contributor Author

@Leko Leko Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same adobe #17458 (comment)

assert(instance instanceof Cipher, 'Cipher is expected to return a new ' +
'instance when called without `new`');

common.expectsError(
() => new Cipher(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "cipher" argument must be of type string'
});

common.expectsError(
() => new Cipher('aes-256-cbc', null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "password" argument must be one of type string, Buffer, ' +
'TypedArray, or DataView'
});

common.expectsError(
() => new Cipher('aes-256-cbc', 'secret').update(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "data" argument must be one of type string, Buffer, ' +
'TypedArray, or DataView'
});

common.expectsError(
() => new Cipher('aes-256-cbc', 'secret').setAuthTag(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "buffer" argument must be one of type Buffer, ' +
'TypedArray, or DataView'
});

common.expectsError(
() => new Cipher('aes-256-cbc', 'secret').setAAD(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "buffer" argument must be one of type Buffer, ' +
'TypedArray, or DataView'
});
}

{
const Decipher = crypto.Decipher;
const instance = crypto.Decipher('aes-256-cbc', 'secret');
Copy link
Copy Markdown
Contributor

@maclover7 maclover7 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createDecipher

assert(instance instanceof Decipher, 'Decipher is expected to return a new ' +
'instance when called without `new`');
Copy link
Copy Markdown
Member

@lpinca lpinca Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indent once more.

Copy link
Copy Markdown
Contributor Author

@Leko Leko Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a silly mistake.
I'll fix it soon.


common.expectsError(
() => new Decipher(null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "cipher" argument must be of type string'
});

common.expectsError(
() => new Decipher('aes-256-cbc', null),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "password" argument must be one of type string, Buffer, ' +
'TypedArray, or DataView'
});
}

// Base64 padding regression test, see #4837.
{
const c = crypto.createCipher('aes-256-cbc', 'secret');
Expand Down