Skip to content

Enhance crypto/hash.js coverage #17447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 7 commits into from
Closed

Enhance crypto/hash.js coverage #17447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77f61dc
test: Add test call Hash without new keyword
Leko Dec 4, 2017
d5ba19d
test: Add test call Hmac without new keyword
Leko Dec 4, 2017
b38e323
test: Add test call Hmac with hmac=null
Leko Dec 4, 2017
cfa073a
test: Add test call Hmac with hmac=string, key=null
Leko Dec 4, 2017
4dc97af
test: add missing key parameter
Leko Dec 4, 2017
380a158
test: add space after new line
Leko Dec 4, 2017
6a96751
test: use factory method instead of constructor
Leko Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add space after new line 
Right now it says "instance when".
  • Loading branch information
@Leko
Leko committed Dec 4, 2017
commit 380a158b263aa36265099a44d06d6a6c0a1f6813
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-hash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,5 @@ common.expectsError(
const Hash = crypto.Hash;
const instance = crypto.Hash('sha256');
Copy link
Copy Markdown
Contributor

@maclover7 maclover7 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createHash

Copy link
Copy Markdown
Contributor Author

@Leko Leko Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same adobe #17458 (comment)

assert(instance instanceof Hash, 'Hash is expected to return a new instance' +
Copy link
Copy Markdown
Contributor

@apapirovski apapirovski Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a space either at the end of this line (after instance) or on the next line. Right now it says "instancewhen".

Copy link
Copy Markdown
Contributor Author

@Leko Leko Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Sorry. I'll update it soon.

'when called without `new`');
' when called without `new`');
}
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-hmac.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const crypto = require('crypto');
const Hmac = crypto.Hmac;
const instance = crypto.Hmac('sha256', 'Node');
Copy link
Copy Markdown
Contributor

@maclover7 maclover7 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createHmac

assert(instance instanceof Hmac, 'Hmac is expected to return a new instance' +
Copy link
Copy Markdown
Contributor

@apapirovski apapirovski Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

'when called without `new`');
' when called without `new`');
}

common.expectsError(
Expand Down