Skip to content

events: remove reaches into _events internals #17440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 4 commits into from
Closed

events: remove reaches into _events internals #17440

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
707fca2
events: remove reaches into _events internals
apapirovski Nov 25, 2017
a9b213c
fixup: address some of mcollina's feedback
apapirovski Dec 6, 2017
db52004
fixup: example for rawListeners
apapirovski Dec 12, 2017
53aab29
fixup: add #on example
apapirovski Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: add #on example
  • Loading branch information
@apapirovski
apapirovski committed Dec 14, 2017
commit 53aab29ce63a53289059f7ce50d486d4824c540c
8 changes: 6 additions & 2 deletions doc/api/events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,13 @@ logFnWrapper.listener();
// logs "log once" to the console and removes the listener
logFnWrapper();

// will return an empty array
emitter.on('log', () => console.log('log persistently'));
// will return a new Array with a single function bound by `on` above
const newListeners = emitter.rawListeners('log');
assert.strictEqual(newListeners.length, 0);

// logs "log persistently" twice
newListeners[0]();
emitter.emit('log');
```

[`--trace-warnings`]: cli.html#cli_trace_warnings
Expand Down