Skip to content

domain: runtime deprecate MakeCallback #17417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasMadsen wants to merge 2 commits into from
Closed

domain: runtime deprecate MakeCallback #17417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe3b5b
domain: runtime deprecate MakeCallback
AndreasMadsen Feb 7, 2018
13facfa
[squash] lint
AndreasMadsen Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] lint
  • Loading branch information
@AndreasMadsen
AndreasMadsen committed Feb 8, 2018
commit 13facfa0ec502114bbbe8fb3bc3de7e11e849500
1 change: 0 additions & 1 deletion lib/domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
const util = require('util');
const EventEmitter = require('events');
const errors = require('internal/errors');
const internalUtil = require('internal/util');
const { createHook } = require('async_hooks');

// overwrite process.domain with a getter/setter that will allow for more
Expand Down
6 changes: 3 additions & 3 deletions test/addons/make-callback-domain-warning/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ const assert = require('assert');
const domain = require('domain');
const binding = require(`./build/${common.buildType}/binding`);

function makeCallback (object, cb) {
binding.makeCallback(object, () => setImmediate(cb))
};
function makeCallback(object, cb) {
binding.makeCallback(object, () => setImmediate(cb));
}

let latestWarning = null;
process.on('warning', function(warning) {
Expand Down