Skip to content

tools,build: .gitignore tweaks #17380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 3 commits into from
Closed

tools,build: .gitignore tweaks #17380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a84f58d
tools,build: .gitignore tweaks
refack Nov 28, 2017
e7cde42
[fixup] refactor sub patterns to deps
refack Nov 30, 2017
869b204
[fixup] moar tweaks
refack Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[fixup] moar tweaks
  • Loading branch information
@refack
refack committed Nov 30, 2017
commit 869b20429175d0e9ee8da13c9ae97a7e4db2c130
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,5 @@ package-lock.json
!/tools/eslint/node_modules**
!/tools/doc/node_modules**
!/test/fixtures/**

# more patterns in /deps/.gitignore
3 changes: 0 additions & 3 deletions deps/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
/openssl/openssl.targets
/openssl/openssl.xml

#openssl/openssl.target.mk
#zlib/zlib.target.mk

!/npm/node_modules**
Copy link
Copy Markdown
Contributor

@MylesBorins MylesBorins Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be !/npm?

Copy link
Copy Markdown
Contributor Author

@refack refack Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other files in /deps/npm aren't ignores by any other rule, only node_modules is. So this is the minimal glob needed.

/npm/node_modules/node-gyp/gyp/**/*.pyc
# not needed and causes issues for distro packagers
Expand Down