Skip to content

src: use nullptr instead of NULL #17373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 6 commits into from
Closed

src: use nullptr instead of NULL #17373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82d200e
src: use nullptr instead of NULL
danbev Nov 27, 2017
62394f2
tools: add cpplint rule for NULL usage
danbev Nov 28, 2017
a621bb9
squash: use word boundry instead of whitespace
danbev Nov 29, 2017
5ccf83a
src: add NOLINT (readability/null_usage)
danbev Nov 29, 2017
3b26697
test: add NOLINT (readability/null_usage)
danbev Nov 29, 2017
f249747
tools: add NOLINT (readability/null_usage)
danbev Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: add NOLINT (readability/null_usage)
  • Loading branch information
@danbev
danbev committed Nov 29, 2017
commit 5ccf83aa494c8a86fa853040d0aac64040527b82
15 changes: 8 additions & 7 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,13 +501,13 @@ extern "C" NODE_EXTERN void node_module_register(void* mod);
{ \
NODE_MODULE_VERSION, \
flags, \
NULL, \
NULL, /* NOLINT (readability/null_usage) */ \
__FILE__, \
(node::addon_register_func) (regfunc), \
NULL, \
NULL, /* NOLINT (readability/null_usage) */ \
NODE_STRINGIFY(modname), \
priv, \
NULL \
NULL /* NOLINT (readability/null_usage) */ \
}; \
NODE_C_CTOR(_register_ ## modname) { \
node_module_register(&_module); \
Expand All @@ -520,23 +520,24 @@ extern "C" NODE_EXTERN void node_module_register(void* mod);
{ \
NODE_MODULE_VERSION, \
flags, \
NULL, \
NULL, /* NOLINT (readability/null_usage) */ \
__FILE__, \
NULL, \
NULL, /* NOLINT (readability/null_usage) */ \
(node::addon_context_register_func) (regfunc), \
NODE_STRINGIFY(modname), \
priv, \
NULL \
NULL /* NOLINT (readability/null_usage) */ \
}; \
NODE_C_CTOR(_register_ ## modname) { \
node_module_register(&_module); \
} \
}

#define NODE_MODULE(modname, regfunc) \
NODE_MODULE_X(modname, regfunc, NULL, 0)
NODE_MODULE_X(modname, regfunc, NULL, 0) // NOLINT (readability/null_usage)

#define NODE_MODULE_CONTEXT_AWARE(modname, regfunc) \
/* NOLINTNEXTLINE (readability/null_usage) */ \
NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)

/*
Expand Down
2 changes: 1 addition & 1 deletion src/node_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ typedef struct {
EXTERN_C_END

#define NAPI_MODULE(modname, regfunc) \
NAPI_MODULE_X(modname, regfunc, NULL, 0)
NAPI_MODULE_X(modname, regfunc, NULL, 0) // NOLINT (readability/null_usage)

#define NAPI_AUTO_LENGTH SIZE_MAX

Expand Down
2 changes: 1 addition & 1 deletion src/node_win32_etw_provider-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ extern int events_enabled;
DWORD status = event_write(node_provider, \
&eventDescriptor, \
0, \
NULL); \
NULL); // NOLINT (readability/null_usage) \
CHECK_EQ(status, ERROR_SUCCESS);


Expand Down