Skip to content

src: replace ->To*(isolate) with ->To*(context).ToLocalChecked() #17343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 8 commits into from
Closed

src: replace ->To*(isolate) with ->To*(context).ToLocalChecked() #17343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e41c511
src: replace ->To*(isolate) with ->To*(context).ToLocalChecked()
Leko Nov 27, 2017
f9107cc
test: use .As<Object> on Exception::Error
Leko Nov 28, 2017
60f4711
test: use .As<Object> instead of ->ToObject
Leko Nov 28, 2017
19a1b2e
test: add test case that crashes when throwing an exception with vm.S…
Leko Nov 28, 2017
1926bcf
src: use FromMaybe instead of ToLocalChecked
Leko Nov 28, 2017
096cbbf
src: pass context to Get()
Leko Nov 28, 2017
dbee7b0
test: add test case that crashes when process.dlopen with undefined
Leko Nov 30, 2017
d7cc341
src: return if Get or ToObject return an empty before call ToLocalChe…
Leko Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use .As<Object> on Exception::Error 
> Exception::Error always returns an object, so e.As<Object>() should also work fine
See #17343 (comment)
  • Loading branch information
@Leko
Leko committed Nov 28, 2017
commit f9107cc2f7fe66f5ac993a1f38d4c9d14606425b
4 changes: 2 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ Local<Value> ErrnoException(Isolate* isolate,
}
e = Exception::Error(cons);

Local<Object> obj = e->ToObject(env->context()).ToLocalChecked();
Local<Object> obj = e.As<Object>();
obj->Set(env->errno_string(), Integer::New(env->isolate(), errorno));
obj->Set(env->code_string(), estring);

Expand Down Expand Up @@ -751,7 +751,7 @@ Local<Value> WinapiErrnoException(Isolate* isolate,
e = Exception::Error(message);
}

Local<Object> obj = e->ToObject(env->context()).ToLocalChecked();
Local<Object> obj = e.As<Object>();
obj->Set(env->errno_string(), Integer::New(isolate, errorno));

if (path != nullptr) {
Expand Down
2 changes: 1 addition & 1 deletion src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ class Parser : public AsyncWrap {
enum http_errno err = HTTP_PARSER_ERRNO(&parser->parser_);

Local<Value> e = Exception::Error(env->parse_error_string());
Local<Object> obj = e->ToObject(env->context()).ToLocalChecked();
Local<Object> obj = e.As<Object>();
obj->Set(env->bytes_parsed_string(), Integer::New(env->isolate(), 0));
obj->Set(env->code_string(),
OneByteString(env->isolate(), http_errno_name(err)));
Expand Down