Skip to content

refactor test-http-exceptions file to use countdown #17199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bamieh wants to merge 6 commits into from
Closed

refactor test-http-exceptions file to use countdown #17199

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb56205
Fixes: https://github.com/nodejs/node/issues/17169 (test-http-excepti…
Bamieh Nov 21, 2017
85adb63
mustCall inside countdown
Bamieh Nov 23, 2017
3610dd3
Add test case for countdown
Bamieh Nov 23, 2017
0d31fc3
Update countdown docs to hint the change
Bamieh Nov 23, 2017
079d736
Update README.md
Bamieh Nov 23, 2017
d624399
Update README.md
Bamieh Nov 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md
  • Loading branch information
@Bamieh
Bamieh authored Nov 23, 2017
commit 079d7367fdab63ce790b7590a0280d781c0f689a
4 changes: 2 additions & 2 deletions test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ Name of the temp directory used by tests.
The `Countdown` module provides a simple countdown mechanism for tests that
require a particular action to be taken after a given number of completed
tasks (for instance, shutting down an HTTP server after a specific number of
requests). Note that the _The Countdown will fail the test if its callback
is not executed_.
requests). Note that _the Countdown will fail the test if the remainder
not reach 0_.

<!-- eslint-disable strict, required-modules -->
```js
Expand Down