Skip to content

Promises/better unhandled rejection message #17158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadaraUchiha wants to merge 6 commits into from
Closed

Promises/better unhandled rejection message #17158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a29fe91
Improved unhandled rejection message
MadaraUchiha Nov 20, 2017
ba4adc5
Make tests pass
MadaraUchiha Nov 20, 2017
ab45e60
Wrap reason with unsafeToString() if it's a string
MadaraUchiha Nov 20, 2017
bf06851
Add test for checking warnings about rejected numbers.
MadaraUchiha Nov 21, 2017
9d29f0c
Fix failing symbol rejection test.
MadaraUchiha Nov 21, 2017
481c7f1
Make test lines wrap at 80 characters or less.
MadaraUchiha Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make tests pass 
For unhandled rejection error message change.
  • Loading branch information
@MadaraUchiha
MadaraUchiha committed Nov 20, 2017
commit ba4adc55f8c5a7ee2879ba9f544bb336e755276d
18 changes: 18 additions & 0 deletions test/message/unhandled_promise_trace_warnings.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
(node:*) UnhandledPromiseRejectionWarning: Error: This was rejected
at * (*test*message*unhandled_promise_trace_warnings.js:*)
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
at *
(node:*) Error: This was rejected
at * (*test*message*unhandled_promise_trace_warnings.js:*)
at *
Expand Down
7 changes: 5 additions & 2 deletions test/parallel/test-promises-unhandled-proxy-rejections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ const expectedDeprecationWarning = 'Unhandled promise rejections are ' +
'rejections that are not handled will ' +
'terminate the Node.js process with a ' +
'non-zero exit code.';
const expectedPromiseWarning = 'Unhandled promise rejection (rejection id: ' +
'1): [object Object]';
const expectedPromiseWarning = 'Unhandled promise rejection. ' +
'This error originated either by throwing ' +
'inside of an async function without a catch ' +
'block, or by rejecting a promise which was ' +
'not handled with .catch(). (rejection id: 1)';

function throwErr() {
throw new Error('Error from proxy');
Expand Down
7 changes: 5 additions & 2 deletions test/parallel/test-promises-unhandled-symbol-rejections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ const expectedDeprecationWarning = 'Unhandled promise rejections are ' +
'rejections that are not handled will ' +
'terminate the Node.js process with a ' +
'non-zero exit code.';
const expectedPromiseWarning = 'Unhandled promise rejection (rejection id: ' +
'1): Symbol()';
const expectedPromiseWarning = 'Unhandled promise rejection. ' +
'This error originated either by throwing ' +
'inside of an async function without a catch ' +
'block, or by rejecting a promise which was ' +
'not handled with .catch(). (rejection id: 1)';

common.expectWarning({
DeprecationWarning: expectedDeprecationWarning,
Expand Down
11 changes: 7 additions & 4 deletions test/parallel/test-promises-warning-on-unhandled-rejection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,21 @@ let b = 0;
process.on('warning', common.mustCall((warning) => {
switch (b++) {
case 0:
assert.strictEqual(warning.name, 'UnhandledPromiseRejectionWarning');
assert(/Unhandled promise rejection/.test(warning.message));
assert.strictEqual(warning.message, 'This was rejected');
break;
case 1:
assert.strictEqual(warning.name, 'DeprecationWarning');
assert.strictEqual(warning.name, 'UnhandledPromiseRejectionWarning');
assert(/Unhandled promise rejection/.test(warning.message), 'Expected warning message to contain "Unhandled promise rejection" but did not. Had "' + warning.message + '" instead.');
Copy link
Copy Markdown
Member

@jasnell jasnell Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines need to be line-wrapped at <= 80 chars

Copy link
Copy Markdown
Contributor Author

@MadaraUchiha MadaraUchiha Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come make test's linter passes for me? I totally missed that.

break;
case 2:
assert.strictEqual(warning.name, 'DeprecationWarning');
break;
case 3:
assert.strictEqual(warning.name, 'PromiseRejectionHandledWarning');
assert(/Promise rejection was handled asynchronously/
.test(warning.message));
}
}, 3));
}, 4));

const p = Promise.reject('This was rejected');
setImmediate(common.mustCall(() => p.catch(() => {})));