Skip to content

doc: require CI status indicator in PRs #17151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seishun wants to merge 2 commits into from
Closed

doc: require CI status indicator in PRs #17151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982dd05
doc: require CI status indicator in PRs
seishun Nov 20, 2017
1809931
if possible
seishun Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: require CI status indicator in PRs 
Commits are often landed despite failing on one or more CI platforms.
Having a CI status indicator in the PR should make this less likely to
happen.
  • Loading branch information
@seishun
seishun committed Nov 20, 2017
commit 982dd05471485720cf26015166bbbb0a8715c07b
1 change: 1 addition & 0 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change.
All pull requests that modify executable code should be subjected to
continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
The pull request should have a CI status indicator.
Copy link
Copy Markdown
Member

@targos targos Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: If the CI job has the option, the pull request should have a CI status indicator.

Copy link
Copy Markdown
Contributor Author

@seishun seishun Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just adding "if possible"?

Copy link
Copy Markdown
Member

@targos targos Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


#### Useful CI Jobs

Expand Down