Skip to content

Allow configure option to link to tcmalloc/ jemalloc #17007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sathvikl wants to merge 1 commit into from
Closed

Allow configure option to link to tcmalloc/ jemalloc #17007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow configure option to link to tcmalloc/ jemalloc 
jemalloc and tcmaloc memory allocators provide better
performance on small sized allocations.
Note that, the comments in the help section clearly warn the user
that, when linking against jemalloc/tcmalloc, alloc() and free()
should route to the same allocator to prevent a crash.

GH Issue #17007 has the performance report attached for jemalloc.
  • Loading branch information
@sathvikl
sathvikl committed Jan 31, 2018
commit e7473ed34277a229fc2580fdc2619a2ce865af1f
53 changes: 53 additions & 0 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,54 @@ parser.add_option('--openssl-system-ca-path',
help='Use the specified path to system CA (PEM format) in addition to '
'the OpenSSL supplied CA store or compiled-in Mozilla CA copy.')

shared_optgroup.add_option('--shared-jemalloc',
action='store_true',
dest='shared_jemalloc',
help='Use jemalloc instead of libc malloc'
'Use this option for custom builds, after examining the impact'
'on performance. Ensure that the native add-on is linked to either'
'libc or jemalloc and uses the same allocator to alloc and free.')

shared_optgroup.add_option('--shared-jemalloc-includes',
action='store',
dest='shared_jemalloc_includes',
help='directory containing lib jemalloc header files')

shared_optgroup.add_option('--shared-jemalloc-libname',
action='store',
dest='shared_jemalloc_libname',
default='jemalloc',
help='alternative lib name to link to [default: %default]')

shared_optgroup.add_option('--shared-jemalloc-libpath',
action='store',
dest='shared_jemalloc_libpath',
help='directory to search for the jemalloc lib')

shared_optgroup.add_option('--shared-tcmalloc',
action='store_true',
dest='shared_tcmalloc',
help='Use tcmalloc instead of libc malloc'
'Use this option for custom builds, after examining the impact'
'on performance. Ensure that the native add-on is linked to either'
'libc or jemalloc and uses the same allocator to alloc and free.')

shared_optgroup.add_option('--shared-tcmalloc-includes',
action='store',
dest='shared_tcmalloc_includes',
help='directory containing lib tcmalloc header files')

shared_optgroup.add_option('--shared-tcmalloc-libname',
action='store',
dest='shared_tcmalloc_libname',
default='tcmalloc',
help='alternative lib name to link to [default: %default]')

shared_optgroup.add_option('--shared-tcmalloc-libpath',
action='store',
dest='shared_tcmalloc_libpath',
help='directory to search for the tcmalloc lib')

shared_optgroup.add_option('--shared-http-parser',
action='store_true',
dest='shared_http_parser',
Expand Down Expand Up @@ -1443,6 +1491,11 @@ configure_library('http_parser', output)
configure_library('libuv', output)
configure_library('libcares', output)
configure_library('nghttp2', output)

# we don't want to link to both tcmalloc and jemalloc
if bool(options.shared_jemalloc) != bool(options.shared_tcmalloc):
configure_library('jemalloc', output)
configure_library('tcmalloc', output)
# stay backwards compatible with shared cares builds
output['variables']['node_shared_cares'] = \
output['variables'].pop('node_shared_libcares')
Expand Down