Skip to content

(v6.x backport) test: refactor test-readline-keys #16947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 1 commit into from
Closed

(v6.x backport) test: refactor test-readline-keys #16947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-readline-keys 
* replace `util._extend()` with `Object.assign()`
* extract repeated map function to a single instance
* remove unneeded truthiness-check ternary on Objects

PR-URL: #11281
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott @tniessen
Trott authored and tniessen committed Nov 11, 2017
commit 41b78eea62fa89b5f9e309ecd2e4ed7e68ff4ba4
13 changes: 6 additions & 7 deletions test/parallel/test-readline-keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const common = require('../common');
const PassThrough = require('stream').PassThrough;
const assert = require('assert');
const inherits = require('util').inherits;
const extend = require('util')._extend;
const Interface = require('readline').Interface;


Expand All @@ -12,6 +11,10 @@ function FakeInput() {
}
inherits(FakeInput, PassThrough);

function extend(k) {
return Object.assign({ ctrl: false, meta: false, shift: false }, k);
}


const fi = new FakeInput();
const fo = new FakeInput();
Expand All @@ -32,9 +35,7 @@ function addTest(sequences, expectedKeys) {
expectedKeys = [ expectedKeys ];
}

expectedKeys = expectedKeys.map(function(k) {
return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k;
});
expectedKeys = expectedKeys.map(extend);

keys = [];

Expand Down Expand Up @@ -65,9 +66,7 @@ const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
expectedKeys = [ expectedKeys ];
}

expectedKeys = expectedKeys.map(function(k) {
return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k;
});
expectedKeys = expectedKeys.map(extend);

const keys = [];
fi.on('keypress', (s, k) => keys.push(k));
Expand Down