Skip to content

tools: replace string concatenation with template literals #16806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lambrojos wants to merge 2 commits into from
Closed

tools: replace string concatenation with template literals #16806

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ac8c6
tools: replace string concatenation with template literals
lambrojos Nov 6, 2017
c6ca7b4
tools: initialize currentText.textRow with a one-liner
lambrojos Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: replace string concatenation with template literals 
Replaces a string concatenation in the processList function
in doc/json.js.
  • Loading branch information
@lambrojos
lambrojos committed Nov 6, 2017
commit e8ac8c60b3a639b0a4b11fe5e5276a085f3cdd93
2 changes: 1 addition & 1 deletion tools/doc/json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ function processList(section) {
JSON.stringify(list));
}
current.textRaw = current.textRaw || '';
current.textRaw += `${tok.text} `;
current.textRaw = `${current.textRaw}${tok.text} `;
Copy link
Copy Markdown
Contributor

@apapirovski apapirovski Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a slightly better way of doing this would be to make it all one line, like so:

current.textRaw = `${current.textRaw || ''}${tok.text} `;

}
});

Expand Down