Skip to content

lib: fix version check in tick processor #16769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 3 commits into from
Nov 7, 2017
+66 −13
Merged

lib: fix version check in tick processor #16769

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
421316d
lib: fix version check in tick processor
bnoordhuis Nov 5, 2017
09d22dd
lib: shuffle v8_prof_polyfill.js for unit testing
bnoordhuis Nov 5, 2017
698bb96
test: tick processor version check regression test
bnoordhuis Nov 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: tick processor version check regression test 
Verify that v8-version log lines are parsed and matched correctly.

Fixes: #16736
PR-URL: #16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Nov 7, 2017
commit 698bb96383e46017d68b44c680f328f7bdf18c45
41 changes: 41 additions & 0 deletions test/parallel/test-tick-processor-version-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Flags: --expose-internals
'use strict';
require('../common');
const assert = require('assert');
const { versionCheck } = require('internal/v8_prof_polyfill');

assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3'), undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.3'), undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.4'), undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.5'), undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3'),
undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3.4'),
undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3-node.1'),
undefined);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3-node.2'),
undefined);
assert.strictEqual(
versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3.4-node.2'),
undefined);

{
const expected = 'Unable to read v8-version from log file.';
assert.strictEqual(versionCheck('faux', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,1', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,1,2', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,1,2,3', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,1,2,3,4', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,1,2,3,4,5,6,7', '1.2.3'),
expected);
}

{
const expected = 'Testing v8 version different from logging version';
assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '1.2.3'), expected);
assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '1.2.3.4'), expected);
assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '4.3.1.1'), expected);
assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '4.3.3.1'), expected);
}