Skip to content

test: fix flaky test-async-wrap-uncaughtexception #16692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

test: fix flaky test-async-wrap-uncaughtexception #16692

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb3dd4d
test: fix flaky test-async-wrap-uncaughtexception
jasnell Nov 2, 2017
7727acf
[Squash] add comment
jasnell Nov 2, 2017
cefeab2
[Squash] testing
jasnell Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] add comment
  • Loading branch information
@jasnell
jasnell committed Nov 2, 2017
commit 7727acfe5991d27e64db7ed874e82a8a9343349f
6 changes: 5 additions & 1 deletion test/parallel/test-async-wrap-uncaughtexception.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ const call_log = [0, 0, 0, 0]; // [before, callback, exception, after];
let call_id = null;
let hooks = null;


// TODO(jasnell): This is using process.once because, for some as yet unknown
// reason, the 'beforeExit' event may be emitted more than once
// under some conditions on variaous platforms. Using the once
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: various

// handler here avoids the flakiness but ignores the underlying
// cause of the flakiness.
process.once('beforeExit', common.mustCall(() => {
process.removeAllListeners('uncaughtException');
hooks.disable();
Expand Down