Skip to content

loader, docs, test: named exports from commonjs modules #16675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devsnek wants to merge 13 commits into from
Closed

loader, docs, test: named exports from commonjs modules #16675

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
81fef20
loader,docs,test: set named exports based on keys from `module.exports`
devsnek Nov 1, 2017
d3647dd
add test for exporting reserved keywords from cjs from esm
devsnek Nov 2, 2017
e8478e2
Slight change of plan with loading (use well-defined __esModule)
devsnek Nov 2, 2017
116b470
Symbol('esModule') exported from `module` builtin
devsnek Nov 2, 2017
1a53fd1
remove comment i forgot to remove
devsnek Nov 2, 2017
ac2b4a1
change up symbol usage, use for(;;), add tests
devsnek Nov 2, 2017
4a1c95a
symbol overrides __esModule
devsnek Nov 2, 2017
49add2b
add back docs for json/c++ addons
devsnek Nov 3, 2017
28f58f6
apparently this is much faster
devsnek Nov 3, 2017
c6da711
this is why you don't commit from github web
devsnek Nov 3, 2017
1220d06
make tests a bit more verbose
devsnek Nov 4, 2017
fe73e26
fix lint
devsnek Nov 4, 2017
c4a6c27
document builtin default export
devsnek Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
document builtin default export
  • Loading branch information
@devsnek
devsnek committed Nov 4, 2017
commit c4a6c27a604961d0431eb02d76356fb414365a57
3 changes: 2 additions & 1 deletion doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ as named exports.
In both cases, this should be thought of like a "snapshot" of the exports at
Copy link
Copy Markdown
Member

@ljharb ljharb Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a snapshot of the values, or just a snapshot of the names?

The latter is necessary, but the former may not be.

Copy link
Copy Markdown
Member Author

@devsnek devsnek Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought just saying exports was ok since its both the names and the values

Copy link
Copy Markdown
Member

@ljharb ljharb Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right - I’m saying that there’s no need for the values to be snapshotted; just the names.

Copy link
Copy Markdown
Member Author

@devsnek devsnek Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it isn't a snapshot, it's just a useful term to describe how it becomes static when assigned in reflection with es imports.

Copy link
Copy Markdown
Member

@ljharb ljharb Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s pretty important to be precise here :-) i think “a snapshot of the names of the exports”, and indicating that if the values are updated, the resulting imports will update as well (a requirement for APM-like use cases, i understand)

the time of importing; asynchronously modifying `module.exports` will not
affect the values of the exports. Builtin libraries are provided with named
exports as if they were using `@@esModuleInterop`.
exports as if they were using `@@esModuleInterop`, as well as the
`module.exports` of the builtin provided as the `default` export.


```js
Expand Down