Skip to content

[v6.x backport] src: do not include x.h if x-inl.h is included #16610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

[v6.x backport] src: do not include x.h if x-inl.h is included #16610

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e4d3c
src: make header file self-contained
joyeecheung Oct 26, 2017
87a379c
src: do not include x.h if x-inl.h is included
joyeecheung Oct 30, 2017
00bd0c8
src: fix etw provider include on Windows
joyeecheung Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: make header file self-contained 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: #16518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 30, 2017
commit b1e4d3c12b3954dc52d0a3133b78a000ae67dfda
1 change: 1 addition & 0 deletions src/node_crypto_clienthello-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "node_crypto_clienthello.h"
#include "util.h"
#include "util-inl.h"

Expand Down