Skip to content

lib: refactor ES module loader for readability (JS side) #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

lib: refactor ES module loader for readability (JS side) #16579

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
580fda4
lib: refactor ES module loader for readability
addaleax Oct 28, 2017
f747deb
[squash] typo
addaleax Oct 29, 2017
32704fd
[squash] timothygu comment
addaleax Oct 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] typo
  • Loading branch information
@addaleax
addaleax committed Oct 29, 2017
commit f747debe08c24d42286d17106886a960b2924683
2 changes: 1 addition & 1 deletion lib/internal/loader/ModuleWrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const createDynamicModule = (exports, url = '', evaluate) => {
);
const names = ArrayMap(exports, (name) => `${name}`);
// Create two modules: One whose exports are get- and set-able ('reflective'),
// and one which re-exports all these of these but additionally may
// and one which re-exports all of these but additionally may
// run an executor function once everything is set up.
const src = `
export let executor;
Expand Down