Skip to content

test: fix flaky test-http-dns-error #16534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bengl wants to merge 1 commit into from
Closed

test: fix flaky test-http-dns-error #16534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-http-dns-error 
Under some conditions, the error received from getaddrinfo might
actually be EAGAIN, meaning the request should be retried. Allowing for
5 retries before erroring out.

Also replace one-off function with common.mustNotCall().
  • Loading branch information
@bengl
bengl committed Oct 26, 2017
commit 182278b490feebfd8187e35e6d406750abaa5f7a
35 changes: 23 additions & 12 deletions test/parallel/test-http-dns-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,30 +30,41 @@ const http = require('http');
const https = require('https');

const host = '*'.repeat(256);
const MAX_TRIES = 5;

function do_not_call() {
throw new Error('This function should not have been called.');
}

function test(mod) {

function tryGet(mod, tries) {
// Bad host name should not throw an uncatchable exception.
// Ensure that there is time to attach an error listener.
const req1 = mod.get({ host: host, port: 42 }, do_not_call);
req1.on('error', common.mustCall(function(err) {
const req = mod.get({ host: host, port: 42 }, common.mustNotCall());
req.on('error', common.mustCall(function(err) {
if (err.code === 'EAGAIN' && tries < MAX_TRIES) {
tryGet(mod, ++tries);
return;
}
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// http.get() called req1.end() for us
}

const req2 = mod.request({
function tryRequest(mod, tries) {
const req = mod.request({
method: 'GET',
host: host,
port: 42
}, do_not_call);
req2.on('error', common.mustCall(function(err) {
}, common.mustNotCall());
req.on('error', common.mustCall(function(err) {
if (err.code === 'EAGAIN' && tries < MAX_TRIES) {
tryRequest(mod, ++tries);
return;
}
assert.strictEqual(err.code, 'ENOTFOUND');
}));
req2.end();
req.end();
}

function test(mod) {
tryGet(mod, 0);
tryRequest(mod, 0);
}

if (common.hasCrypto) {
Expand Down