Skip to content

http2: fix mapToHeaders() with single string value #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinwoo wants to merge 2 commits into from
Closed

http2: fix mapToHeaders() with single string value #16458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb2af57
http2: fix mapToHeaders() with single string value
jinwoo Oct 24, 2017
4f6b1bc
address review comments.
jinwoo Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: fix mapToHeaders() with single string value 
This is for issue 16452. When 'set-cookie' header is set with an array
that has only one string value, it's split into its individual
characters.

Fix by resetting `isArray` to false when the value is converted from an
array to a string.

Fixes: #16452
  • Loading branch information
@jinwoo
jinwoo committed Oct 24, 2017
commit eb2af57c8f3fb79b08d7858e01b3ff5967a42656
3 changes: 2 additions & 1 deletion lib/internal/http2/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,13 +401,14 @@ function mapToHeaders(map,
if (typeof key === 'symbol' || value === undefined || !key)
continue;
key = String(key).toLowerCase();
const isArray = Array.isArray(value);
let isArray = Array.isArray(value);
if (isArray) {
switch (value.length) {
case 0:
continue;
case 1:
value = String(value[0]);
isArray = false;
break;
default:
if (kSingleValueHeaders.has(key))
Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-http2-util-headers-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,17 @@ const {
);
}

{
// Arrays containing a single set-cookie value are handled correctly
// (issue #16452)
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please use the full URL: https://github.com/nodejs/node/issues/16452?

const headers = Object.create({});
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: just {} should be fine here.

headers['set-cookie'] = ['foo=bar'];
assert.deepStrictEqual(
mapToHeaders(headers),
[ [ 'set-cookie', 'foo=bar', '' ].join('\0'), 1 ]
);
}

// The following are not allowed to have multiple values
[
HTTP2_HEADER_STATUS,
Expand Down