Skip to content

doc: how to decode buffers extending from Writable #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dicearr wants to merge 4 commits into from
Closed

doc: how to decode buffers extending from Writable #16403

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9c62de
doc: howto decode buffers extending from Writable
dicearr Oct 23, 2017
0acc2a3
fix: linting errors in example code
dicearr Oct 24, 2017
14140cc
fix: example usage and text changes
dicearr Oct 30, 2017
829d356
fix: renamed _data into data
dicearr Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: linting errors in example code
  • Loading branch information
@dicearr
dicearr committed Oct 24, 2017
commit 0acc2a38993645721eec0068045c62f9bf2a8d62
28 changes: 14 additions & 14 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,26 +1519,26 @@ regressions. The following is an example of how to achieve that extending
[Writable][].

```js
const { Writable } = require('stream')
const { StringDecoder } = require('string_decoder')
const { Writable } = require('stream');
const { StringDecoder } = require('string_decoder');

class StringWritable extends Writable {
constructor (options) {
super(options)
const state = this._writableState
this._decoder = new StringDecoder(state.defaultEncoding)
this._data = ''
constructor(options) {
super(options);
const state = this._writableState;
this._decoder = new StringDecoder(state.defaultEncoding);
this._data = '';
}
_write (chunk, encoding, callback) {
_write(chunk, encoding, callback) {
if (encoding === 'buffer') {
chunk = this._decoder.write(chunk)
chunk = this._decoder.write(chunk);
}
this._data += chunk
callback()
this._data += chunk;
callback();
}
_final (callback) {
this._data += this._decoder.end()
callback()
_final(callback) {
this._data += this._decoder.end();
callback();
}
}
Copy link
Copy Markdown
Member

@mcollina mcollina Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to add a quick example on how to use this.

```
Expand Down