Skip to content

test: mark big string tests flaky on freebsd #16358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 1 commit into from
Closed

test: mark big string tests flaky on freebsd #16358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: mark big string tests flaky on freebsd 
Some of the addons/stringbytes-external-exceed-max tests are known flaky
after the upgrade to V8 6.2.  The most likely reason is the increase of
the maximum string length from 256 to 1024 MB, pushing their execution
times over the time limit.

Fixes: #16354
Refs: #15362
  • Loading branch information
@bnoordhuis
bnoordhuis committed Oct 21, 2017
commit ffc04cfb7d5bd53a690c581cccfed4c6b5d28175
10 changes: 10 additions & 0 deletions test/addons/addons.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
prefix addons

# https://github.com/nodejs/node/issues/16354 - known flaky after the upgrade
# to V8 6.2 in https://github.com/nodejs/node/pull/15362. Most likely reason
# is the increase of the maximum string length from 256 to 1024 MB, pushing
# their execution times over the time limit.
[$system==freebsd]
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: FLAKY,PASS
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: FLAKY,PASS
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: FLAKY,PASS
2 changes: 1 addition & 1 deletion test/addons/testcfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
import testpy

def GetConfiguration(context, root):
return testpy.AddonTestConfiguration(context, root, 'addon')
return testpy.AddonTestConfiguration(context, root, 'addons')