Skip to content

[v6.x backport] tty: require readline at top of file #16264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bengl wants to merge 14 commits into from
Closed

[v6.x backport] tty: require readline at top of file #16264

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b8ab430
build: call setlocal in vcbuild.bat
danbev Oct 2, 2017
3991953
doc: fix incorrect vm.createContext usage
tshemsedinov Oct 7, 2017
c405f95
src: fix ^ in stack trace with vm's columnOffset
TimothyGu Oct 4, 2017
c81b425
test: remove messages in assert.strictEqual
Saeed-Navarik Oct 6, 2017
6d49154
doc: update style guide for markdown extension
Trott Oct 5, 2017
d0157b7
test: alter assert.strictEqual to default message
gishmel Oct 6, 2017
0c0717c
test: replacing assert message with template
Oct 6, 2017
bf1bf28
test: improve assert messages
ericljpemberton Oct 6, 2017
d3544c1
doc: add clearer setup description
craftninja Oct 6, 2017
b43fed4
test: replace literal with template string
brantphoto Oct 6, 2017
97cf4f1
tools: use template literals
sarahmeyer Oct 6, 2017
a686f9c
test: removed string from assert message arg
dpaulino Oct 6, 2017
b93842a
test: changes to use template literal
joanne-jjb Oct 6, 2017
5dc4b25
tty: require readline at top of file
bengl Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add clearer setup description 
Updated console example to follow style of rest of the examples

PR-URL: #15962
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@craftninja @MylesBorins
craftninja authored and MylesBorins committed Oct 17, 2017
commit d3544c1e2b2eea5482289a6a6ecf9b4723435bc1
5 changes: 4 additions & 1 deletion BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ To run the tests:
$ make test
```

At this point you are ready to make code changes and re-run the tests!
Optionally, continue below.

To run the tests and generate code coverage reports:

```console
Expand All @@ -145,7 +148,7 @@ and overwrites the `lib/` directory. To clean up after generating the coverage
reports:

```console
make coverage-clean
$ make coverage-clean
```

To build the documentation:
Expand Down