Skip to content

Fix --without-intl #16251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 2 commits into from
+12 −6
Closed

Fix --without-intl #16251

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f42a9cc
src: fix NewContext for --without-intl
TimothyGu Oct 17, 2017
456ebc3
benchmark: fix punycode test for --without-intl
TimothyGu Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix NewContext for --without-intl
  • Loading branch information
@TimothyGu
TimothyGu committed Oct 17, 2017
commit f42a9cce98622e5085b3389c3460a7e1e78f7265
4 changes: 2 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4777,9 +4777,9 @@ Local<Context> NewContext(Isolate* isolate,
auto intl_key = FIXED_ONE_BYTE_STRING(isolate, "Intl");
auto break_iter_key = FIXED_ONE_BYTE_STRING(isolate, "v8BreakIterator");
Local<Value> intl_v;
Local<Object> intl;
if (context->Global()->Get(context, intl_key).ToLocal(&intl_v) &&
intl_v->ToObject(context).ToLocal(&intl)) {
intl_v->IsObject()) {
Local<Object> intl = intl_v.As<Object>();
intl->Delete(context, break_iter_key).FromJust();
}
return context;
Expand Down