Skip to content

Fix --without-intl #16250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 2 commits into from
Closed

Fix --without-intl #16250

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f42a9cc
src: fix NewContext for --without-intl
TimothyGu Oct 17, 2017
456ebc3
benchmark: fix punycode test for --without-intl
TimothyGu Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
benchmark: fix punycode test for --without-intl
  • Loading branch information
@TimothyGu
TimothyGu committed Oct 17, 2017
commit 456ebc3b349f2b6ea3eaa5e8f0da37148baad6f2
14 changes: 10 additions & 4 deletions benchmark/misc/punycode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
'use strict';

const common = require('../common.js');
const icu = process.binding('icu');
let icu;
try {
icu = process.binding('icu');
} catch (err) {}
const punycode = require('punycode');

const bench = common.createBenchmark(main, {
method: ['punycode', 'icu'],
method: ['punycode'].concat(icu !== undefined ? ['icu'] : []),
n: [1024],
val: [
'افغانستا.icom.museum',
Expand Down Expand Up @@ -69,8 +72,11 @@ function main(conf) {
runPunycode(n, val);
break;
case 'icu':
runICU(n, val);
break;
if (icu !== undefined) {
runICU(n, val);
break;
}
// fallthrough
default:
throw new Error('Unexpected method');
}
Expand Down