tools: update to ESLint 4.8.0#16199
Closed
apapirovski wants to merge 2 commits into
Closed
Conversation
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it.
jasnell
approved these changes
Oct 14, 2017
hiroppy
approved these changes
Oct 14, 2017
Trott
previously requested changes
Oct 14, 2017
bd1fb2c to
dfc0467
Compare
Contributor
Author
|
@Trott fixed now. Thanks! (This will teach me not to make a PR jet-lagged on a Friday night. 😂 I even knew that script was there.) |
Still seems to update about 70 more files than I get when I do it locally, but I suppose that might be due to different versions of npm or something like that...
cjihrig
approved these changes
Oct 14, 2017
Contributor
Author
|
@Trott I get 497 (16 more) now but eslint just released 4.9.0 so that's probably the reason for the difference. I'm using |
Contributor
|
The difference in changed-file count might be due to updated |
BridgeAR
approved these changes
Oct 18, 2017
Contributor
Author
apapirovski
added a commit
to apapirovski/node
that referenced
this pull request
Oct 19, 2017
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: nodejs#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
apapirovski
added a commit
to apapirovski/node
that referenced
this pull request
Oct 19, 2017
PR-URL: nodejs#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: #16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: nodejs/node#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
This is going to need to be backported to v6.x Most likely it will make sense to simply update the 6.x branch directly and label this one don't land |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: nodejs/node#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit addresses an extraneous space in
lib/modules.jswhich seems to go unnoticed in v4.3.0 ofeslintbut gets flagged by v4.8.0. The second commit upgrades toeslint@4.8.0. This mimics the PRs for 4.2.0 & 4.3.0 upgrades.Here's the changelog: https://github.com/eslint/eslint/blob/master/CHANGELOG.md (Quite a few bug fixes & also some perf changes so I figured it was worth upgrading)
/cc @Trott (since you did the 4.2.0 & 4.3.0 updates)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib, tools