Skip to content

test: improve coverage for process.umask #16188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evanlucas wants to merge 1 commit into from
Closed

test: improve coverage for process.umask #16188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve coverage for process.umask 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.
  • Loading branch information
@evanlucas
evanlucas committed Oct 13, 2017
commit f5e3cfe5f4107c31f06de069bf12af881d0b4612
8 changes: 8 additions & 0 deletions test/parallel/test-umask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,11 @@ assert.strictEqual(parseInt(mask, 8), process.umask(old));
assert.strictEqual(old, process.umask());
// 2. If the test fails, process.umask() will return 0
assert.strictEqual(old, process.umask());

assert.throws(() => {
process.umask({});
}, /argument must be an integer or octal string/);

assert.throws(() => {
process.umask('123x');
}, /invalid octal string/);