Skip to content

build: don't compile debug build with -Og #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
May 4, 2015
Merged

build: don't compile debug build with -Og #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: don't compile debug build with -Og 
It's not supported by clang and commit e67542a ("build: disable -Og
when building with clang") is not sufficient because the configure
script no longer writes the 'clang' variable to common.gypi.

I could fix the configure script but I don't care enough actually do
so.  A fixed configure script won't help anyway when the compiler is
overridden through the CXX environment variable at compile time.

PR-URL: #1611
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed May 4, 2015
commit 69581b2767766353e496bd98f91d4701a6014254
9 changes: 2 additions & 7 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
'node_tag%': '',
'uv_library%': 'static_library',

# Default to -Og for debug builds.
# Default to -O0 for debug builds.
'v8_optimized_debug%': 0,

# Enable disassembler for `--print-code` v8 options
Expand Down Expand Up @@ -54,13 +54,8 @@
'v8_enable_handle_zapping%': 1,
},
'defines': [ 'DEBUG', '_DEBUG' ],
'cflags': [ '-g' ],
'cflags': [ '-g', '-O0' ],
'conditions': [
['clang==1', {
'cflags': [ '-O0' ], # https://llvm.org/bugs/show_bug.cgi?id=20765
}, {
'cflags': [ '-Og' ], # Debug-friendly optimizations only.
}],
['target_arch=="x64"', {
'msvs_configuration_platform': 'x64',
}],
Expand Down