Skip to content

improved assert message on cluster-worker-disconnect #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hadis-Fard wants to merge 3 commits into from
Closed

improved assert message on cluster-worker-disconnect #16021

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a202214
imporoved assert message on cluster-worker-disconnect
Oct 6, 2017
dbf78b6
removed messages from strict equal
Oct 23, 2017
5ea39ad
changed single qoute to backtick
Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
imporoved assert message on cluster-worker-disconnect
  • Loading branch information
Hadis-Fard committed Oct 6, 2017
commit a2022142b1442a8cede06320ce3907138b313859
6 changes: 3 additions & 3 deletions test/parallel/test-cluster-worker-disconnect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ if (cluster.isWorker) {
// Disconnect worker when it is ready
worker.once('listening', common.mustCall(() => {
const w = worker.disconnect();
assert.strictEqual(worker, w, 'did not return a reference');
assert.strictEqual(worker, w, '${worker.id} did not return a reference');
Copy link
Copy Markdown
Member

@jasnell jasnell Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This needs backticks on the string literal rather than single quote marks.

}));

// Check cluster events
Expand Down Expand Up @@ -98,9 +98,9 @@ if (cluster.isWorker) {

// flags
assert.strictEqual(w.state, 'disconnected',
'The state property was not set');
'The state property was not set, current state is ${w.state}');
assert.strictEqual(w.voluntaryMode, true,
'Voluntary exit mode was not set');
'Voluntary exit mode was not set, current voluntary mode is ${w.voluntaryMode}');
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line length is to long. It would actually be best to just remove the message overall. The message from strictEqual should be better than the current situation. The same applies to w.state.


// is process alive
assert.ok(w.died, 'The worker did not die');
Expand Down