Skip to content

test: expand error message #15991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharpstef wants to merge 3 commits into from
+12 −7
Closed

test: expand error message #15991

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a91ed7e
test: expand error message
sharpstef Oct 6, 2017
07c3e3d
test: Add constant for isDead result
sharpstef Oct 15, 2017
86cb372
test: store exit isDead status
sharpstef Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions test/parallel/test-cluster-worker-isdead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ const assert = require('assert');

if (cluster.isMaster) {
const worker = cluster.fork();
assert.ok(
!worker.isDead(),
'isDead() should return false right after the worker has been created.');
const workerDead = worker.isDead();
assert.ok(!workerDead,
`isDead() returned ${workerDead}. isDead() should return false ` +
'right after the worker has been created.');

worker.on('exit', function() {
assert.ok(worker.isDead(),
'After an event has been emitted, isDead should return true');
assert.ok(workerDead,
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have failed:

not ok 282 parallel/test-cluster-worker-isdead
  ---
  duration_ms: 0.460
  severity: fail
  stack: |-
    assert.js:45
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: isDead() returned false. After an event has been emitted, isDead should return true
        at Worker.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-cluster-worker-isdead.js:14:12)
        at emitTwo (events.js:136:13)
        at Worker.emit (events.js:227:7)
        at ChildProcess.worker.process.once (internal/cluster/master.js:184:12)
        at Object.onceWrapper (events.js:335:30)
        at emitTwo (events.js:136:13)
        at ChildProcess.emit (events.js:227:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:210:12)
  ...
ok 283 parallel/test-cluster-worker-kill

We cannot use the cached variable here. Please restore this to worker.isDead()

`isDead() returned ${workerDead}. After an event has been ` +
'emitted, isDead should return true');
});

worker.on('message', function(msg) {
Expand All @@ -21,7 +23,9 @@ if (cluster.isMaster) {
});

} else if (cluster.isWorker) {
assert.ok(!cluster.worker.isDead(),
'isDead() should return false when called from within a worker');
const workerDead = cluster.worker.isDead();
assert.ok(!workerDead,
`isDead() returned ${workerDead}. isDead() should return `+
'false when called from within a worker');
process.send('readyToDie');
}