Skip to content

test: replace fixturesdir use common.fixtures #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pauljohnberry wants to merge 5 commits into from
Closed

test: replace fixturesdir use common.fixtures #15973

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e010f9c
test: replace fixturesdir use common.fixtures
pauljohnberry Oct 6, 2017
c117347
test: replace fixturesdir use common.fixtures
pauljohnberry Oct 6, 2017
86dd0dc
test: replace resolve use path method
pauljohnberry Oct 6, 2017
5f5da58
test: remove unused var path
pauljohnberry Oct 7, 2017
963a833
test: removal of new line
pauljohnberry Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replace fixturesdir use common.fixtures
  • Loading branch information
@pauljohnberry
pauljohnberry committed Oct 6, 2017
commit e010f9cc38b8faf8dd1a3781902b18eb7b70bec7
4 changes: 3 additions & 1 deletion test/parallel/test-http2-respond-file-fd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
Expand All @@ -13,7 +14,8 @@ const {
HTTP2_HEADER_CONTENT_LENGTH
} = http2.constants;

const fname = path.resolve(common.fixturesDir, 'elipses.txt');
const fname = path.resolve(fixtures.fixturesDir, 'elipses.txt');

Copy link
Copy Markdown
Member

@tniessen tniessen Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This does not really need the newline IMO.

Copy link
Copy Markdown
Contributor Author

@pauljohnberry pauljohnberry Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tniessen I agree, removed now.

const data = fs.readFileSync(fname);
const stat = fs.statSync(fname);
const fd = fs.openSync(fname, 'r');
Expand Down