Skip to content

test: replaced common.fixturesDir with fixtures.path #15927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mckalexee wants to merge 2 commits into from
Closed

test: replaced common.fixturesDir with fixtures.path #15927

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceca1a7
test: replaced fixturesDir with fixtures module
mckalexee Oct 6, 2017
16f758d
test: replaced common.fixturesDir with fixtures.path
mckalexee Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replaced fixturesDir with fixtures module 
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with# Please enter
the commit message for your changes. Lines starting
the fixturesDir on the common/fixtures module in the path-resolve test.
  • Loading branch information
@mckalexee
mckalexee committed Oct 6, 2017
commit ceca1a7707055266c2aed7f88dd514c597fa5e0c
3 changes: 2 additions & 1 deletion test/parallel/test-path-resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
const assert = require('assert');
const child = require('child_process');
const path = require('path');
Expand Down Expand Up @@ -62,7 +63,7 @@ if (common.isWindows) {
// Test resolving the current Windows drive letter from a spawned process.
// See https://github.com/nodejs/node/issues/7215
const currentDriveLetter = path.parse(process.cwd()).root.substring(0, 2);
const resolveFixture = path.join(common.fixturesDir, 'path-resolve.js');
const resolveFixture = path.join(fixtures.fixturesDir, 'path-resolve.js');
const spawnResult = child.spawnSync(
process.argv[0], [resolveFixture, currentDriveLetter]);
const resolvedPath = spawnResult.stdout.toString().trim();
Expand Down