Skip to content

test: cleanup test-buffer-sharedarraybuffer test suite #15896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RafLeszczynski wants to merge 1 commit into from
Closed

test: cleanup test-buffer-sharedarraybuffer test suite #15896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: cleanup test-buffer-sharedarraybuffer 
remove third argument `0` from calls to `assert.deepStrictEqual`
  • Loading branch information
@RafLeszczynski
RafLeszczynski committed Oct 6, 2017
commit 18389f92cf8e5f27ca1964fca42a148f64f4edea
6 changes: 3 additions & 3 deletions test/parallel/test-buffer-sharedarraybuffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ arr2[1] = 4000;
const arr_buf = Buffer.from(arr1.buffer);
const ar_buf = Buffer.from(arr2.buffer);

assert.deepStrictEqual(arr_buf, ar_buf, 0);
assert.deepStrictEqual(arr_buf, ar_buf);

arr1[1] = 6000;
arr2[1] = 6000;

assert.deepStrictEqual(arr_buf, ar_buf, 0);
assert.deepStrictEqual(arr_buf, ar_buf);

// Checks for calling Buffer.byteLength on a SharedArrayBuffer

assert.strictEqual(Buffer.byteLength(sab), sab.byteLength, 0);
assert.strictEqual(Buffer.byteLength(sab), sab.byteLength);

assert.doesNotThrow(() => Buffer.from({ buffer: sab }));