Skip to content

test: use template literals in test-string-decoder #15884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earobinson wants to merge 2 commits into from
Closed

test: use template literals in test-string-decoder #15884

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d33075
test: use template literals in test-string-decoder
earobinson Oct 6, 2017
4cd32ba
Resolved comments
earobinson Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use template literals in test-string-decoder 
`test/parallel/test-string-decoder.js` used to use string concatenation
this was migrated to use template literals. When concatenation
involved a newline we kept string concatenation, or to keep below 80
charters per line.
  • Loading branch information
@earobinson
earobinson committed Oct 10, 2017
commit 4d3307579bbcb3e48bb2cf36fcc889eb8df71df6
10 changes: 5 additions & 5 deletions test/parallel/test-string-decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@ function test(encoding, input, expected, singleSequence) {
output += decoder.end();
if (output !== expected) {
const message =
'Expected "' + unicodeEscape(expected) + '", ' +
'but got "' + unicodeEscape(output) + '"\n' +
'input: ' + input.toString('hex').match(hexNumberRE) + '\n' +
'Write sequence: ' + JSON.stringify(sequence) + '\n' +
'Full Decoder State: ' + inspect(decoder);
`Expected "${unicodeEscape(expected)}", ` +
`but got "${unicodeEscape(output)}"\n ` +
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: there seems to be a trailing space here that wasn't present previously.

Copy link
Copy Markdown
Contributor Author

@earobinson earobinson Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

`input: ${input.toString('hex').match(hexNumberRE)}\n` +
`Write sequence: ${JSON.stringify(sequence)}\n` +
`Full Decoder State: ${inspect(decoder)}`;
assert.fail(output, expected, message);
}
});
Expand Down