Skip to content

test: replace common.fixturesDir with usage of the common.fixtures #15870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alodela wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with usage of the common.fixtures #15870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: replace common.fixturesDir with usage of the common.fixtures in 
test-https-close
  • Loading branch information
@alodela
alodela committed Oct 6, 2017
commit f06f6b766f64f3245361ca2d786b61ba5da204a2
5 changes: 3 additions & 2 deletions test/parallel/test-https-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would you mind moving this after the common.hasCrypto check?

if (!common.hasCrypto)
common.skip('missing crypto');

const fs = require('fs');
const https = require('https');

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
};

const connections = {};
Expand Down