Skip to content

test: fix actual and expected order in asserts #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skysteve wants to merge 1 commit into from
Closed

test: fix actual and expected order in asserts #15866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
assert: fix actual and expected order
  • Loading branch information
@skysteve
skysteve committed Oct 6, 2017
commit 44c8694b9fa2ae481c22955cdb1de7278b0e2a49
10 changes: 5 additions & 5 deletions test/parallel/test-vm-run-in-new-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ common.globalCheck = false;

// Run a string
const result = vm.runInNewContext('\'passed\';');
assert.strictEqual('passed', result);
assert.strictEqual(result, 'passed');

// Thrown error
assert.throws(() => {
Expand All @@ -42,7 +42,7 @@ assert.throws(() => {

global.hello = 5;
vm.runInNewContext('hello = 2');
assert.strictEqual(5, global.hello);
assert.strictEqual(global.hello, 5);


// Pass values in and out
Expand All @@ -54,9 +54,9 @@ global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
const baz = vm.runInNewContext(global.code, global.obj);
/* eslint-enable no-unused-vars */
assert.strictEqual(1, global.obj.foo);
assert.strictEqual(2, global.obj.bar);
assert.strictEqual(2, global.foo);
assert.strictEqual(global.obj.foo, 1);
assert.strictEqual(global.obj.bar, 2);
assert.strictEqual(global.foo, 2);

// Call a function by reference
function changeFoo() { global.foo = 100; }
Expand Down